Commands should not be resolved in cwd #150

New Issue

FWDekker · 2020-12-07T14:38:43+01:00

FWDekker commented

2020-12-07 14:38:43 +01:00

If cwd is ~ and the command ~/example exists, then executing example should never execute ~/example, even if /bin/example does not exist. That is, after implementing #148, cwd should not be on path.

Therefore, if the command (i.e. first word) of a line contains no slashes, then look up from path. Otherwise, look up normally (i.e. relative or absolute, depending on the path).

The only exception here is directories. These work as follows: If no slash, then look up from path, otherwise normal resolution but RETURN ONLY IF DIRECTORY. If slash, normal resolution applies.

If cwd is `~` and the command `~/example` exists, then executing `example` should never execute `~/example`, even if `/bin/example` does not exist. That is, after implementing #148, cwd should not be on path. Therefore, if the command (i.e. first word) of a line contains no slashes, then look up from path. Otherwise, look up normally (i.e. relative or absolute, depending on the path). The only exception here is directories. These work as follows: If no slash, then look up from path, otherwise normal resolution but RETURN ONLY IF DIRECTORY. If slash, normal resolution applies.

FWDekker added the

enhancement

label 2020-12-07 14:38:43 +01:00

FWDekker self-assigned this 2020-12-07 14:38:43 +01:00

FWDekker referenced this issue from a commit

2020-12-07 14:48:35 +01:00

Adjust resolution semantics for security Fixes #150.

FWDekker closed this issue

2020-12-07 14:48:35 +01:00

Sign in to join this conversation.