Deprecate replaceAll #70

New Issue

FWDekker · 2019-11-11T20:53:03+01:00

FWDekker commented

2019-11-11 20:53:03 +01:00

The replaceAll function was used to replace all occurrences of a substring in a string, but this should be replaced by a simple replace using a regex wherever possible.

The difference is that "aaa".replaceAll(/aa/, "a") equals "a" whereas "aaa".replace(/aa/, "a") equals"aa", which may be a more natural interpretation in some cases.

The `replaceAll` function was used to replace all occurrences of a substring in a string, but this should be replaced by a simple `replace` using a regex wherever possible. The difference is that `"aaa".replaceAll(/aa/, "a")` equals `"a"` whereas `"aaa".replace(/aa/, "a")` equals`"aa"`, which may be a more natural interpretation in some cases.

FWDekker self-assigned this 2019-11-11 20:53:03 +01:00

FWDekker added the

code-quality

label 2019-11-11 20:53:03 +01:00

FWDekker referenced this issue from a commit

2019-11-11 22:59:54 +01:00

Deprecate `replaceAll` function Fixes #70.

FWDekker closed this issue

2019-11-11 22:59:54 +01:00

Sign in to join this conversation.