tools
/
debreviator
1
0
Fork 1
Code Issues Pull Requests Releases Activity

Assortment of fixes #9

Merged
FWDekker merged 4 commits from wukl/debreviator:master into master 2023-02-08 16:13:13 +01:00
Conversation 0 Commits 4 Files Changed 3 +5 -3
wukl commented 2023-02-01 15:13:10 +01:00
Contributor
Copy Link

A few small changes:

  1. Transform the input acronym to lowercase. The word list is all-lowercase, so if an upper- or mixed-case acronym was entered, no word would match. The quickest fix is to transform the input acronym to lowercase.

  2. The big blue button didn't do anything; you had to submit the form by pressing enter on the input field. Fixed by changing the type from button to submit.

  3. Errors were not displayed due to a missing container. Added one again.

  4. Bumped the revision to 0.0.7.

A few small changes: 1. Transform the input acronym to lowercase. The word list is all-lowercase, so if an upper- or mixed-case acronym was entered, no word would match. The quickest fix is to transform the input acronym to lowercase. 2. The big blue button didn't do anything; you had to submit the form by pressing enter on the input field. Fixed by changing the type from `button` to `submit`. 3. Errors were not displayed due to a missing container. Added one again. 4. Bumped the revision to 0.0.7.
wukl added 4 commits 2023-02-01 15:13:12 +01:00
035fa6a34b Have the big button submit the form 
Instead of doing nothing at all
wukl requested review from FWDekker 2023-02-01 16:44:10 +01:00
FWDekker approved these changes 2023-02-08 16:11:15 +01:00
FWDekker left a comment
Owner
Copy Link

LGTM

LGTM
FWDekker merged commit 6827422bf0 into master 2023-02-08 16:13:13 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
FWDekker
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tools/debreviator#9
No description provided.
Delete Branch "wukl/debreviator:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?